Repository navigation
fix(build): declare explicit gzip build-depend for image assembly - #460
Conversation
🐝 Possible duplicateThis PR changes exactly the same files as #458, which was opened first:
Evidence — identical changed-file set (2 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
There was a problem hiding this comment.
Looks correct to me; verified rather than inferred:
freedesktop-sdk.bst:components/cracklib.bst(at the pinnedfreedesktop-sdk-26.08.2ref) hasintegration-commandsthat runcreate-cracklib-dict, which pipes throughgzip— so the image-assembly sandbox does need gzip at integration time, exactly as described.components/gzip.bstexists at that FSDK ref._build_depends()intests/unit/test_build_depends.py:118already handles both string andfilename:dict entries, so the new assertion is sound. Ran the file: 5 passed onmain, 6 passed with this diff applied.- Checked the interaction with #458 (sed):
git merge-treeof the two PR heads merges cleanly — the.bstinserts are separated by themtoolsline and the two tests anchor at different spots, as the body says. Either can land first.
One file-set note for whoever merges: this and #458 are the same class of fix on the same element but are not duplicates (different tool, different consumer); both should land.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Sandbox integration runs create-cracklib-dict (via cracklib-format, a shell script piping through gzip), but the element only reached gzip transitively, so the FSDK 26.08.0 -> 26.08.2 bump dropped it and the nightly build logged 'gzip: command not found'. Declare freedesktop-sdk.bst:components/gzip.bst explicitly, mirroring the sed fix for projectbluefin#456, plus a regression test so it cannot silently go missing again. Closes projectbluefin#459. Assisted-by: Muse Spark via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: projectbluefin#459 Hive-Plan: projectbluefin#459 Hive-Spec: projectbluefin#459#gzip-sandbox Signed-off-by: j1mc <j1mc@users.noreply.github.com>
Review follow-up: the dependency was never declared; the FSDK junction bump did not remove it. Assisted-by: Claude Fable 5.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8054b64 to
8545c90
Compare
The server OS image is assembled from parts inside an isolated build workspace that only contains tools explicitly listed in its recipe. One of the automatic setup steps rebuilds a password-strength dictionary using a helper script that needs the gzip compression tool. After a routine platform update, gzip silently disappeared from that workspace, so the nightly build log shows an error from the helper script. The build still succeeds today, but the dictionary it produces is suspect, and the next platform update could turn this into a hard failure. This change lists gzip as an explicit requirement in the recipe, plus a small automated check so it cannot silently go missing again.
What changed
Evidence
Note: this branch is cut from my fork's main, which trails upstream main, because the token available here lacks the workflow scope needed to publish a branch whose tree updates workflow files relative to the stale fork default. The diff against upstream main is just the two files above, in regions untouched since the fork point, so it merges cleanly (also alongside PR #458: the gzip line sits between findutils and mtools, the sed line between mtools and systemd, and the two regression tests anchor at different spots).
Closes #459.
— hive: backend=pi model=openrouter/meta/muse-spark-1.3-contributor
🐝 Hive Agent:
contributor| SHA:5e5bac8