Repository navigation
Conversation
The required govulncheck check fails on every new CI run, including the merge queue, because Go 1.26.6 has nine standard-library vulnerabilities (net/http, net/textproto, crypto/tls) that are fixed in Go 1.26.9. Move every exact Go pin from 1.26.6 to 1.26.9: the go.mod directive and the setup-go version in ci.yml, nightly.yml, release.yml and security.yml. Same change as #868 made for 1.26.5 -> 1.26.6.
castrojo
approved these changes
Oct 13, 2026
castrojo
left a comment
Collaborator
There was a problem hiding this comment.
Approving Go toolchain pin bump to 1.26.9. All CI checks are green (build+test, govulncheck, coverage gate, headless e2e, cross-compile arm64). Resolves stdlib CVEs flagged by govulncheck.
castrojo
enabled auto-merge
October 13, 2026 17:01
castrojo
disabled auto-merge
October 13, 2026 17:07
castrojo
enabled auto-merge
October 13, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves knuckle's Go version from 1.26.6 to 1.26.9. This is the
goline ingo.modand thego-versiongiven toactions/setup-goin four workflows. No Go code changes..github/workflows/ci.yml.github/workflows/nightly.yml.github/workflows/release.yml.github/workflows/security.ymlgo.modWhy
govulncheckis a required check, and it has failed on every CI run since 2026-10-10, including the merge queue. Go 1.26.6 has nine standard-library vulnerabilities that knuckle's code reaches, and all of them are fixed in Go 1.26.9:Source: the
govulncheckjob in merge-queue run 38127820735. Every finding reads "Found in: …@go1.26.6, Fixed in: …@go1.26.9".So nothing can merge right now. #928 has been dropped from the merge queue on every attempt since 2026-10-10 09:16 UTC, and the other open dependency PRs (#923, #927, #929, #931) will hit the same failure.
This is the same change as #868, which moved the pin from 1.26.5 to 1.26.6 for the same reason.
How tested
just ciis green locally (details below: everything passed except two steps that fail on this machine for reasons unrelated to this change)just vm-e2epasses (end-to-end install + boot)just headless-testpasses (for headless-mode changes)Run locally with Go 1.26.9 (
GOTOOLCHAIN=go1.26.9):go mod tidy: no changes, so go.mod and go.sum stay clean.gofmt -l,go vet ./...andgolangci-lint run ./...: clean.go test -race ./...: all 18 packages pass.govulncheck ./...(v1.7.0, as in CI): "Your code is affected by 0 vulnerabilities", exit 0.just shell-lintandjust build: pass.Two
just cisteps fail on this machine, and they fail the same way on unchangedmain:just cover-check:internal/headlesscomes out at 98% against a 99% target. Unchangedmainwith Go 1.26.6 gives the same 98% here. CI'scoverage gatejob passes onmain.just headless-test: the Flatcar dry-run passes. The FCOS dry-run stops because the recipe writes to/tmp, which is out of space on this machine. CI'sheadless e2e (dry-run)job passes onmain.Scope check
No change to what knuckle supports. Only the Go version used to build and test it moves.
Notes for reviewers
vm-e2e.ymlasks forgo-version: "1.26"with no patch number, so it already gets the latest 1.26 release. It's unchanged here, as it was in fix(deps): bump Go toolchain pin to 1.26.6 #868.AGENTS.mdsays a toolchain bump should also addtoolchain goX.Y.Ztogo.mod. I left that out on purpose:go mod tidydeletes atoolchainline that matches thegoline, so it would fail the "go.mod clean after tidy" step injust ci.mainhas notoolchainline today either. The same note saysci.ymlhas two Go pins; it has seven. I'm happy to fix that note in a follow-up.GOTOOLCHAIN=auto,godownloads it automatically.