make caching a separate interface#66
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR separates client-side cache metrics from the main ValkeyCommands composite interface by introducing a dedicated CachedValkeyCommands interface and adding cached-specific constructors in the Valkey DSL.
Changes:
- Removed
CacheMetricsfrom the baseValkeyCommandstrait. - Added
CachedValkeyCommands(type-level marker for “caching enabled” + metrics). - Added cached factory methods (
utf8Cached,fromConfigCached,fromClusterConfigCached, and*CachedUnsafe) plus cached command implementations (CachedValkeyStandalone/CachedValkeyCluster) and aCacheMetricsImplmixin.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/effects/src/main/scala/dev/profunktor/valkey4cats/ValkeyCommands.scala | Drops cache metrics from the default composite commands interface. |
| modules/effects/src/main/scala/dev/profunktor/valkey4cats/Valkey.scala | Adds cached-specific DSL constructors returning CachedValkeyCommands. |
| modules/effects/src/main/scala/dev/profunktor/valkey4cats/CachedValkeyCommands.scala | Introduces the new caching-aware commands interface (ValkeyCommands + CacheMetrics). |
| modules/effects/src/main/scala/dev/profunktor/valkey4cats/BaseValkey.scala | Extracts cache metrics implementation into a mixin and adds cached command implementations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3600
to
3605
| private def liftAndMap[A, B](cf: java.util.concurrent.CompletableFuture[A])(f: A => B): F[B] = | ||
| asyncF.map(futureLift.lift(cf))(f) | ||
|
|
||
| override def cacheHitRate: F[Double] = | ||
| baseClient.getCacheHitRate().futureLift.map(_.doubleValue()) | ||
| liftAndMap(baseClient.getCacheHitRate())(_.doubleValue()) | ||
|
|
| @@ -21,4 +21,3 @@ trait ValkeyCommands[F[_], K, V] | |||
| with ScriptingCommands[F, K, V] | |||
| with ServerCommands[F, K, V] | |||
| with ConnectionCommands[F, K, V] | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.