Skip to content

fix(merch): reject non-decimal numeric options#806

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/merch-decimal-options
Jul 22, 2026
Merged

fix(merch): reject non-decimal numeric options#806
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/merch-decimal-options

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • add strict parsers for merch quantity, price, markup, and budget cap options
  • reject scientific and hexadecimal numeric strings that JavaScript Number() would otherwise accept
  • add direct regression coverage for merch numeric options

Tests

  • node_modules/.bin/vitest.CMD run packages/cli/src/commands/merch.test.ts
  • node_modules/.bin/tsc.CMD -p packages/cli/tsconfig.json --noEmit
  • git diff --check

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

5 similar comments
@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio
ralyodio merged commit 040b482 into profullstack:master Jul 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants