Skip to content

Base custom build commands from project to workspace path#2722

Merged
samsinsane merged 1 commit into
premake:masterfrom
nickclark2016:ninja-rebase-custom-build-commands
Jun 26, 2026
Merged

Base custom build commands from project to workspace path#2722
samsinsane merged 1 commit into
premake:masterfrom
nickclark2016:ninja-rebase-custom-build-commands

Conversation

@nickclark2016

Copy link
Copy Markdown
Member

What does this PR do?

Partially addresses #2714 - Fixes paths to be relative to workspace instead of project.

How does this PR change Premake's behavior?

Translated paths are relative to the workspace for Ninja, not projects.

Anything else we should know?

There is discussion to be had for fixing detoken functionality. It appears that detokenization of paths is being done against an incorrect base directory.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from a team June 24, 2026 00:37
@samsinsane samsinsane merged commit c950bf7 into premake:master Jun 26, 2026
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants