Add Windows MSVC test support: rng_fail, alloc, wycheproof, unit, (C backend only)#1738
Add Windows MSVC test support: rng_fail, alloc, wycheproof, unit, (C backend only)#1738willieyz wants to merge 3 commits into
Conversation
CBMC Results (ML-KEM-512)
Full Results (191 proofs)
|
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
7cd4bfa to
6bba531
Compare
e66e8b4 to
05c7d8e
Compare
05c7d8e to
42710fe
Compare
There was a problem hiding this comment.
@willieyz, thanks!
It's not true that we don't have tests on Windows. We do have tests on Windows using Mingw-w64. Can you adjust the commit message to reflect the gap you are closing (Tests on Windows using MSVC).
mkannwischer
left a comment
There was a problem hiding this comment.
Also can we please close the remaining gap in a single PR, i.e, rng_fail, unit, alloc, wycheproof - that should all be straightforward?
42710fe to
33d36ae
Compare
mlkem-native already runs tests on Windows via Mingw-w64, but the MSVC/nmake build has no rng_fail test coverage. This commit adds the link rules to Makefile.Microsoft_nmake to enable rng_fail tests against the portable C backend under MSVC. Signed-off-by: willieyz <willie.zhao@chelpis.com>
mlkem-native already runs tests on Windows via Mingw-w64, but the MSVC/nmake build has no alloc test coverage. This commit adds the compile and link rules to Makefile.Microsoft_nmake to enable alloc tests against the portable C backend under MSVC. Signed-off-by: willieyz <willie.zhao@chelpis.com>
mlkem-native already runs tests on Windows via Mingw-w64, but the MSVC/nmake build has no wycheproof test coverage. This commit adds the compile and link rules to Makefile.Microsoft_nmake, also add the run_wycheproof target, to enable wycheproof tests against the portable C backend under MSVC. Signed-off-by: willieyz <willie.zhao@chelpis.com>
cc7a6d0 to
a0adc8e
Compare
Hello @mkannwischer, Thank you for the review! Thanks again for taking the time to review and for the feedback. |
mlkem-native already runs tests on Windows via Mingw-w64, but the MSVC/nmake build only covers the functional tests. This PR closes the remaining gap by adding the following tests to
Makefile.Microsoft_nmake, against the portable C backend:rng_fail: link rules added.alloc: addedtest/src/test_alloc.candtest/configs/test_alloc_config.h, referencing the Linux Makefile. Needs to rebuild the.objfiles since it uses a different config from the default functional test. A newALLOC_CFLAGSmacro keeps the build rules short.wycheproof: test obj building rules and link rules added.