poly: Deduplicate poly_decompose and poly_use_hint#1159
Draft
mkannwischer wants to merge 1 commit into
Draft
Conversation
poly_decompose and poly_use_hint depend only on GAMMA2, so ML-DSA-65
and -87 use identical code. Move them into the shared poly.c as
mld_poly_decompose_{88,32} and mld_poly_use_hint_{88,32}, compiled
once, with thin dispatchers in poly_kl.h, so a multilevel build shares
a single copy instead of emitting one per parameter set. The native
backend dispatch moves into the value-specialized variants, dropping
the parameter-set checks.
The underlying rounding.h helpers mld_decompose and mld_use_hint are
likewise split into value-specialized variants written against the
parameter-set independent constants MLDSA_GAMMA2_{88,32}; the original
dispatching forms are removed as they have no remaining users.
Split the CBMC proofs into per-variant proofs plus dispatcher proofs.
- Towards #536
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (210 proofs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poly_decompose and poly_use_hint depend only on GAMMA2, so ML-DSA-65 and -87 use identical code. Move them into the shared poly.c as mld_poly_decompose_{88,32} and mld_poly_use_hint_{88,32}, compiled once, with thin dispatchers in poly_kl.h, so a multilevel build shares a single copy instead of emitting one per parameter set. The native backend dispatch moves into the value-specialized variants, dropping the parameter-set checks.
The underlying rounding.h helpers mld_decompose and mld_use_hint are likewise split into value-specialized variants written against the parameter-set independent constants MLDSA_GAMMA2_{88,32}; the original dispatching forms are removed as they have no remaining users.
Split the CBMC proofs into per-variant proofs plus dispatcher proofs.