fix: resolve resSchema namespace for shared response schemas#72
Open
arlindaxhemailii wants to merge 1 commit into
Open
fix: resolve resSchema namespace for shared response schemas#72arlindaxhemailii wants to merge 1 commit into
arlindaxhemailii wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a response schema is shared across multiple tags, the resolver correctly assigns it to the default (
Common) namespace. However, passing the endpoint tag asnamespaceTagtogetImportedZodSchemaNamebypassed this resolution logic and forced the schema into the endpoint's namespace.As a result, shared schemas such as
StatusResponseSchemawere emitted as:RocketsModels.StatusResponseSchemainstead of:
CommonModels.StatusResponseSchemaThis left
resSchemaundefined at runtime, causing successful responses to fail validation and surface asopenapi.sharedErrors.unknownError.This fixes the regression introduced in 3.0.0 by removing the
namespaceTagoverride for response schemas and restoring automatic namespace resolution throughgetTagByZodSchemaName.Also adds regression tests covering both resolution paths:
CommonModelsRocketsModels)