Repository navigation
ci: add informational Windows selftest job and fix its failures - #765
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes match the intended informational scope and leave required checks unchanged.
Review effort: Balanced
Findings: None
What changed in this PR
Adds informational Windows coverage to VIP’s CI to expose locale-encoding bugs and platform assumptions without blocking merges.
Changes:
- Runs selftests and product-test collection on Windows with Python 3.12.
- Uploads test results while keeping Windows outside required checks.
- Documents the new non-blocking job.
| File | Description |
|---|---|
| AGENTS.md | Documents informational Windows coverage. |
| .github/workflows/ci.yml | Adds the Windows job and results artifact. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ian-flores
changed the title
ian-flores
marked this pull request as ready for review
October 6, 2026 21:21
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
selftest-windowsjob toci.ymlthat runs the selftests onwindows-latestwith Python 3.12, and fixes the failures its first run turned up. CI had no Windows coverage, so the Windows-only failure in #752 (a UTF-8 manifest that could not be read under the cp1252 default) could not have been caught.The job is informational for now. It sets
continue-on-error: trueand is deliberately not in theneedsofSelftests Status, so a red run cannot block a merge.PYTHONUTF8is intentionally unset so the job runs with Windows' default locale encoding. It haspermissions: contents: read.The first run had 8 failures out of 2074 selftests. This PR fixes 7 of them in a second commit:
C:\Users\...path into a TOML basic string, where\Uis an invalid escape. They now usejson.dumps(str(path)), which is a valid TOML basic string.test_clients_connect.pypassed-keyout /dev/null. It now writes the throwaway key next to the cert.test_keeps_owner_only_permissionsis skipped on Windows, which has no POSIX0600mode bits.parse_feature_filereturnedstr(path.relative_to(...)), which uses backslashes on Windows. It now returns.as_posix(). This is a product-code change: thefilefield feedsscripts/generate-test-catalog.pyandscripts/generate-feature-matrix.py, which write the website JSON.The remaining failure is
test_ci_ruff_action_has_no_version_override, a bareread_text()that raisesUnicodeDecodeError: 'charmap'. That is fixed by #759, so this job stays informational until #759 picks it up. Once #759 is rebased onto this, its own Windows run should be green, and the job can move into theselftestmatrix and become blocking.