Skip to content

Ship one copy of the DuckDB native library instead of three #16480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliasilge wants to merge 2 commits into from
Closed

Ship one copy of the DuckDB native library instead of three #16480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9a3fea
Share one DuckDB install across the DuckDB extensions
juliasilge Oct 7, 2026
24be1c8
Package `positron-data-driver-duckdb` without npm dependencies
juliasilge Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/lib/extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ function fromLocalEsbuild(extensionPath: string, esbuildConfigFileName: string):
const extensionsWithNpmDeps = [
'positron-duckdb',
'positron-data-driver-databricks',
'positron-data-driver-duckdb',
'positron-data-driver-pins'
];

Expand Down
9 changes: 3 additions & 6 deletions build/lib/positron-path-budget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ export function describeBudget(): string {
* The budgets do not count gzip copies or source maps, which only some builds
* ship. See `isUnbudgeted` in positron-check-path-lengths.ts.
*
* The expected count is about 15,900; the budget leaves about 10% headroom
* The expected count is about 15,500; the budget leaves about 10% headroom
* above it.
*/
export const EXTENSIONS_FILE_COUNT_BUDGET = 17_500;
export const EXTENSIONS_FILE_COUNT_BUDGET = 17_100;

/**
* File-count budget for an extension that `EXTENSION_FILE_COUNT_BUDGETS` does not
Expand All @@ -108,11 +108,8 @@ export const EXTENSION_FILE_COUNT_BUDGETS: ReadonlyMap<string, number> = new Map
['copilot', 8_500], // 7,728
['positron-python', 5_950], // about 5,020; about 5,400 on win32-x64
['positron-pdf-server', 450], // 407
['positron-data-driver-pins', 260], // 233
['positron-duckdb', 230], // 206
['positron-data-driver-duckdb', 215], // 192
['node_modules', 345], // about 312: 129 plus the shared DuckDB packages (#14265)
['markdown-language-features', 190], // 167
['node_modules', 150], // 129
['theme-modern-icons', 140], // 121
]);

Expand Down
146 changes: 145 additions & 1 deletion extensions/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions extensions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"license": "MIT",
"description": "Dependencies shared by all extensions",
"dependencies": {
"@duckdb/node-api": "1.5.5-r.3",
"typescript": "^6.0.3"
},
"scripts": {
Expand Down
6 changes: 3 additions & 3 deletions extensions/positron-data-driver-duckdb/esbuild.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ run({
outdir: outDir,
additionalOptions: {
// @duckdb/node-api loads a native N-API addon (@duckdb/node-bindings) plus a
// prebuilt libduckdb; externalize so it's loaded from node_modules at runtime
// (positron-data-driver-duckdb is registered in extensionsWithNpmDeps so its
// dependencies are packaged). Unlike better-sqlite3, the N-API binding is
// prebuilt libduckdb; externalize so it's loaded at runtime from the single copy
// shared by all DuckDB extensions in extensions/node_modules (declared in
// extensions/package.json). Unlike better-sqlite3, the N-API binding is
// ABI-stable across Node and Electron, so no electron-rebuild is required and
// this extension does not need an .npmrc to inherit the root electron build config.
// Only duckdbWorker.ts imports these; the extension host bundle never loads
Expand Down
Loading
Loading