Repository navigation
Use license files without root activation - #212
Merged
Merged
Conversation
Copy Workbench license files into the service data directory so the non-root server can read them without license-manager activate-file. Skip copying files already there and only deactivate key or server licenses on exit.
Render the existing Workbench versions from the corrected startup template so older images avoid root-only license file activation.
bschwedler
requested review from
GCRev,
ianpittwood,
skyeturriff,
ssinnott and
zachhannum
as code owners
September 25, 2026 14:31
bschwedler
enabled auto-merge
September 25, 2026 14:39
ianpittwood
approved these changes
Sep 25, 2026
jacpete
approved these changes
Sep 25, 2026
jacpete
left a comment
jacpete
left a comment
There was a problem hiding this comment.
This looks good to me. It matches the Connect pattern plus an attempt to change ownership to rstudio-server:rstudio-server if the user is root. I'd expect this to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workbench should read license files from its service data directory instead of calling
license-manager activate-file, which requires root. This lets non-root containers use file-based licensing without running key-license deactivation on exit.The fix is rendered into all eight existing Workbench versions.