fix(checkout): take embed iframe color-scheme from the link's theme - #15135
Merged
Merged
Conversation
A Checkout Link that already carries ?theme=dark, embedded without a theme option, rendered a dark page inside an iframe pinned to color-scheme: light. Chromium only keeps a cross-origin iframe transparent when both resolve to the same scheme, so the overlay turned into a solid dark box on every host. The iframe color-scheme and loader colors now come from the theme on the final checkout URL, the value the embedded page reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DfajvcRYudGibEqduNG7fc
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes the embedded checkout iframe and loader color scheme to follow the theme on the final checkout URL, matching the embedded page's resolved theme, with regression tests for both cases.
Re-trigger cubic
sebastianekstrom
approved these changes
Oct 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checkout link can carry
?theme=darkbut be embedded without athemeoption, rendering a dark mode page inside an iframe pinned tocolor-scheme: light. Chromium only keeps a cross-origin iframe transparent when both resolve to the same scheme, so the overlay turned into a solid dark box on every host.The iframe color-scheme and loader colors now always come from the theme on the final checkout URL, the value the embedded page reads.