chore: remove unused OPTIMIZATION_OBJECTIVE constant - #14160
Merged
detail-app[bot] merged 1 commit intoSep 9, 2026
Merged
detail-app[bot] merged 1 commit into
detail-app[bot] merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
OpenAPI ChangesNo changes detected in the OpenAPI schema. |
pieterbeulque
removed their request for review
September 7, 2026 07:42
psincraian
approved these changes
Sep 9, 2026
detail-app
Bot
deleted the
detail/dead-code/chore-remove-unused-optimization-objective-constan-73f90b
branch
September 9, 2026 08:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the unused
OPTIMIZATION_OBJECTIVEstring constant fromserver/polar/organization_review/eval/optimize.py.What
Deletes the
OPTIMIZATION_OBJECTIVEmodule-level string literal (15 lines) from the GEPA optimization adapter module.Why
The constant had no consumers anywhere in the codebase. It was not passed to
gepa.optimize()(verified by reading the call site), not referenced inside the module, not used by theeval_organization_reviews optimizeCLI subcommand, and not imported by any other file. All other symbols inoptimize.py(run_optimization,ReviewAdapter,_score,_VERDICT_MAP, weights, dataset helpers) are transitively live, wired up via the CLI inserver/scripts/eval_organization_reviews.py.How
Verified via repo-wide grep that
OPTIMIZATION_OBJECTIVEhas a single match — its own definition. ConfirmedReviewAdapter.evaluate/make_reflective_dataset/propose_new_textsare required by thegepaframework (called directly on every iteration). After removal,py_compile, module import,ruff check, andruff format --checkall pass.History
Checklist
uv run task lint && uv run task lint_types)Dead Code PRs can be configured here.