Skip to content

feat: new SPFx version v1.24.0 - #124

Merged
DonKirkham merged 1 commit into
mainfrom
release/v1.24.0
Oct 28, 2026
Merged

DonKirkham merged 1 commit into
mainfrom
release/v1.24.0

Conversation

@DonKirkham

Copy link
Copy Markdown
Collaborator

Summary

  • @microsoft/generator-sharepoint 1.24.0 on node:26.12.1 (SPFx 1.24.0 supports Node 22.14+, 24.x and 26.x)
  • Pinned global tools: yo@7.0.1, @rushstack/heft@1.3.2, pnpm@12.16.1, and yarn@1.22.22 (the Node 26 base image no longer ships yarn)
  • latest / online tags and docs point to 1.24.0

Breaking changes

  • Default user is now node (uid/gid 1000, HOME=/home/node) instead of the custom spfx user (uid 1001). It matches the usual host uid, so --user $(id -u):$(id -g) and the devcontainer's remoteUser: node get a real home directory. The no-op usermod -aG sudo is gone (sudo was never installed).
  • VOLUME is now declared after the /usr/app ownership setup.

Known issue: pnpm with generator 1.24.0

Projects scaffolded with --package-manager pnpm fail heft build with TS2416 on dataVersion: pnpm installs two peer variants of @microsoft/sp-core-library@1.24.0-rc.0 (the generator still pins its sp-* packages to -rc.0). This reproduces with pnpm 11 and 12 and with Node 22 and 26, so it's upstream in the generator. npm-based projects build fine. pnpm stays in the image, the issue is documented in the README, and the CI test stage now scaffolds with npm.

README

  • Per-shell run commands (Bash/zsh, PowerShell, cmd) with -u node and a ~/.rushstack mount so the dev certificate survives --rm
  • Trusting the dev certificate (WSL→Windows, PowerShell, macOS)
  • serve.json ipAddress: 0.0.0.0 step in "Working in the container"
  • "Building the image locally" section (with --load); "Available tags" moved to the bottom

Test plan

  • docker buildx bake test passes locally on linux/amd64 and linux/arm64 (npm scaffold + heft build)
  • Image smoke test: node user, HOME=/home/node, Node v26.12.1, global package versions as above; --user $(id -u):$(id -g) can write to the bind mount
  • CI green
  • After merge: tag v1.24.0 and run build-and-push

Follow-up: bump to node:26.13.0 (current LTS, "Lithium") once the image is published on Docker Hub.

🤖 Generated with Claude Code

- generator-sharepoint 1.24.0 on node:26.12.1
- pin yo 7.0.1, heft 1.3.2, pnpm 12.16.1, add yarn 1.22.22
- run as the base image's node user (uid 1000) instead of spfx (uid 1001)
- test stage scaffolds with npm (pnpm hits a duplicate sp-core-library bug in 1.24.0)
- README: per-shell run commands, .rushstack cert mount, cert trust, serve.json ipAddress

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 28, 2026 21:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The README’s -u node examples assume UID/GID 1000, preventing users with different host IDs from scaffolding files or saving certificates unless ownership and writable-directory setup are addressed.

1 open issue
What changed in this PR

Updates the SharePoint Framework development image to SPFx 1.24.0 and refreshes its container usage guidance.

Changes:

  • Upgrades Node and pins global tools, switches the default user to node, and adjusts volume ownership setup.
  • Uses npm for scaffold-and-build validation while documenting the pnpm build issue.
  • Updates release references and adds shell-specific commands, certificate persistence and trust instructions, and local-build guidance.
File Description
README.md Updates usage, certificates, troubleshooting, local builds, and release tags.
Dockerfile Updates runtime and tools, user setup, and npm-based build validation.
DevelopmentContainers.md Points the devcontainer example to SPFx 1.24.0.
CONTRIBUTING.md Uses cd ~ instead of the former user's home path.

Review effort: Balanced

Comment thread README.md Resolved
@DonKirkham
DonKirkham merged commit 9c339b5 into main Oct 28, 2026
3 checks passed
@DonKirkham
DonKirkham deleted the release/v1.24.0 branch October 28, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants