Repository navigation
feat: new SPFx version v1.24.0 - #124
Merged
Merged
Conversation
- generator-sharepoint 1.24.0 on node:26.12.1 - pin yo 7.0.1, heft 1.3.2, pnpm 12.16.1, add yarn 1.22.22 - run as the base image's node user (uid 1000) instead of spfx (uid 1001) - test stage scaffolds with npm (pnpm hits a duplicate sp-core-library bug in 1.24.0) - README: per-shell run commands, .rushstack cert mount, cert trust, serve.json ipAddress Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The README’s -u node examples assume UID/GID 1000, preventing users with different host IDs from scaffolding files or saving certificates unless ownership and writable-directory setup are addressed.
1 open issue
What changed in this PR
Updates the SharePoint Framework development image to SPFx 1.24.0 and refreshes its container usage guidance.
Changes:
- Upgrades Node and pins global tools, switches the default user to
node, and adjusts volume ownership setup. - Uses npm for scaffold-and-build validation while documenting the pnpm build issue.
- Updates release references and adds shell-specific commands, certificate persistence and trust instructions, and local-build guidance.
| File | Description |
|---|---|
| README.md | Updates usage, certificates, troubleshooting, local builds, and release tags. |
| Dockerfile | Updates runtime and tools, user setup, and npm-based build validation. |
| DevelopmentContainers.md | Points the devcontainer example to SPFx 1.24.0. |
| CONTRIBUTING.md | Uses cd ~ instead of the former user's home path. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
@microsoft/generator-sharepoint1.24.0 onnode:26.12.1(SPFx 1.24.0 supports Node 22.14+, 24.x and 26.x)yo@7.0.1,@rushstack/heft@1.3.2,pnpm@12.16.1, andyarn@1.22.22(the Node 26 base image no longer ships yarn)latest/onlinetags and docs point to 1.24.0Breaking changes
node(uid/gid 1000,HOME=/home/node) instead of the customspfxuser (uid 1001). It matches the usual host uid, so--user $(id -u):$(id -g)and the devcontainer'sremoteUser: nodeget a real home directory. The no-opusermod -aG sudois gone (sudo was never installed).VOLUMEis now declared after the/usr/appownership setup.Known issue: pnpm with generator 1.24.0
Projects scaffolded with
--package-manager pnpmfailheft buildwithTS2416ondataVersion: pnpm installs two peer variants of@microsoft/sp-core-library@1.24.0-rc.0(the generator still pins itssp-*packages to-rc.0). This reproduces with pnpm 11 and 12 and with Node 22 and 26, so it's upstream in the generator. npm-based projects build fine. pnpm stays in the image, the issue is documented in the README, and the CI test stage now scaffolds with npm.README
-u nodeand a~/.rushstackmount so the dev certificate survives--rmserve.jsonipAddress: 0.0.0.0step in "Working in the container"--load); "Available tags" moved to the bottomTest plan
docker buildx bake testpasses locally on linux/amd64 and linux/arm64 (npm scaffold +heft build)nodeuser,HOME=/home/node, Node v26.12.1, global package versions as above;--user $(id -u):$(id -g)can write to the bind mountv1.24.0and run build-and-pushFollow-up: bump to
node:26.13.0(current LTS, "Lithium") once the image is published on Docker Hub.🤖 Generated with Claude Code