Skip to content

feat(migration): add type renaming to resolve native asset name conflicts#472

Open
MyvTsv wants to merge 1 commit intopluginsGLPI:mainfrom
MyvTsv:ticket42658
Open

feat(migration): add type renaming to resolve native asset name conflicts#472
MyvTsv wants to merge 1 commit intopluginsGLPI:mainfrom
MyvTsv:ticket42658

Conversation

@MyvTsv
Copy link
Copy Markdown
Contributor

@MyvTsv MyvTsv commented Apr 17, 2026

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !42658
  • It is not possible to migrate an asset from the genericobject plugin if its name is similar to an asset in the GLPI core. This fix allows users to rename an asset so they can continue the migration.

Screenshots (if appropriate):

Conflict:
image

Migrate
image

@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz April 17, 2026 15:43
@MyvTsv MyvTsv self-assigned this Apr 17, 2026
@Rom1-B
Copy link
Copy Markdown
Contributor

Rom1-B commented Apr 20, 2026

Does this apply to names that are too long? And CLI ?

@stonebuzz
Copy link
Copy Markdown
Contributor

CLI compatibility would be a plus.

@stonebuzz
Copy link
Copy Markdown
Contributor

At the time of renaming, it should also be ensured that the total length (PluginGenericObject + New name) does not exceed the maximum allowed size for MySQL table names.

Copy link
Copy Markdown
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.
Could you add a check that alerts if the table name exceeds 64 characters?
In the CLI, add at least one check and a message to prompt renaming in the interface.

@MyvTsv MyvTsv requested review from Lainow and removed request for Lainow April 24, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants