feat(migration): add type renaming to resolve native asset name conflicts#472
Open
MyvTsv wants to merge 1 commit intopluginsGLPI:mainfrom
Open
feat(migration): add type renaming to resolve native asset name conflicts#472MyvTsv wants to merge 1 commit intopluginsGLPI:mainfrom
MyvTsv wants to merge 1 commit intopluginsGLPI:mainfrom
Conversation
Contributor
|
Does this apply to names that are too long? And CLI ? |
Contributor
|
CLI compatibility would be a plus. |
Contributor
|
At the time of renaming, it should also be ensured that the total length (PluginGenericObject + New name) does not exceed the maximum allowed size for MySQL table names. |
Rom1-B
requested changes
Apr 23, 2026
Contributor
Rom1-B
left a comment
There was a problem hiding this comment.
It works.
Could you add a check that alerts if the table name exceeds 64 characters?
In the CLI, add at least one check and a message to prompt renaming in the interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (if appropriate):
Conflict:

Migrate
