fix(skill): correct and slim the bundled skills; add plivo-first-agent - #107
Merged
Merged
Conversation
…ables at the docs, restore write-safety notes - Cut the skill from 666 to 208 lines (~21k to ~6.5k tokens): one platform matrix instead of four, one hangup table with the top codes, and no per-platform command blocks or plivo sip reference table. - Point the full hangup table, SIP REFER details, geo permissions, account limits, STIR/SHAKEN, signaling ranges and India KYC/regulations at the docs pages that carry them (each resolved with plivo docs show). - Drop dated facts (limit tiers, the account-creation cutoff, the diagnose server-side status, CIDR lists, Vapi IPs) in favor of those pages. - Restore write-safety notes: numbers update reroutes a live number with no --yes gate, record the binding first; deletes cascade and the preview omits numbers; updates to live trunks and URIs land immediately; the secure flag check and inbound-only readiness steps; list paging. - Rewrite the description in third person, under 400 characters.
Drop the flag tables and restated rules that copied `plivo <cmd> --help`. Keep one rules block, the command map, the behaviour help does not show, and a single known-issues note for `voice streams forward`. List every command that ignores --dry-run and acts for real (login, logout, auth use/remove, config set/telemetry, feedback, upgrade, voice streams test), and note that `voice multiparty create` is retired. The README no longer describes a flag table.
…lements at the docs - Cut the body from ~21k to ~6k tokens: drop restated attribute tables, duplicated code tables, the 8011 shape catalogue and 10 of 13 patterns. - Keep GetDigits, GetInput and Dial inline; point Conference, MultiPartyCall, Wait, PreAnswer, DTMF and Message at their docs pages. - Add a validate, fix, repeat loop (xmllint, POST probe, dry-run call). - Settle Conference stayAlone, list fallback timing under docs disagreements, fix the Conference link, keep a non-table Speak language as untested. - Shorten the description to 393 characters.
…ence tables at the docs Cut the skill from 1,068 to 356 lines (about 36k to 11k tokens). The five gates, six checklist steps and eight stages are now one eight-stage flow; duplicated rules are stated once; the India deep dive, second hangup tables, callback and signature recipe, URL fragments, outbound and MultiPartyCall material are replaced by `plivo docs show` pointers whose pages were checked for the removed facts. Corrections: stage 8 no longer filters out 4010 and uses the API's 20-per-page maximum; the Dial action URL does not receive the B-leg hangup fields; `streams test --bidirectional` sends no stop or close frame; organisations are switched with `plivo login` and `plivo auth use`; contentType and keepCallAlive verdicts are consistent; one precedence rule for `--help`. The v1.1.x `streams forward` limitation and the `docs show` page truncation are listed under Known issues.
…number-move and deploy warnings
…p recipe, India and silence checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #103 forward (its commits are kept as authored) plus a rewrite that makes the bundled skills much smaller, and fixes the review findings on #103. Supersedes #103 and #96.
npx skillsfound only 3 of the 6 skills on main; they find all of them now, and a test checks every bundled skill's frontmatter.plivo skill install first-agentguides a new user to a first AI voice agent on a real call. It requires CLI v1.1.3 or later, which is the first release whosevoice streams forwardcan carry a call.plivo docs show <path>, each checked against the page), and repeated or time-sensitive text is gone.--dry-run, the stream-watch filter that hid failed streams, the Dial callback fields, the first-agent test loop (restart after.envedits, never overwrite a filled.env), and a warning before publishing an unauthenticated bot.Testing:
go test -race ./...(including the strict frontmatter test), golangci-lint (0 issues),go vet(also-tags internal), Windows / Linux arm64 /-tags internalbuilds,make docsdrift,go mod tidy -diffandscripts/smoke.shpass. Each slimmed skill was also handed to a fresh agent with no other context and four real tasks (preview-only CLI use, XML writing, docs lookups, safety calls): 16 of 16 tasks succeeded, and the gaps they reported are fixed here.Size
Added lines by type, blank lines excluded. Comments counts comment lines in non-test code.
Removed: 2,725 lines. Tests include 3 comment lines.