Repository navigation
Signify Paddle Classic usage (first stage) - #6814
Merged
Merged
Conversation
aerosol
marked this pull request as ready for review
October 27, 2026 14:33
zoldar
approved these changes
Oct 28, 2026
zoldar
left a comment
zoldar
left a comment
Contributor
There was a problem hiding this comment.
There's still some stuff that could be segmented, like paddle integration specific components (paddle_script, paddle checkout etc.). That can be dealt with gradually later on though. What's already here, looks good 👍
| config :plausible, :paddle, | ||
| config :plausible, :paddle_classic, | ||
| vendor_auth_code: paddle_auth_code, | ||
| vendor_id: paddle_vendor_id |
Contributor
There was a problem hiding this comment.
No big deal, but perhaps rename those variables to paddle_classic_[auth_code|vendor_id] to avoid getting accidentally bitten later on? Env vars could stay as they are for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to hopefully make it simpler to later on differentiate which is which.