Skip to content

Improve safety checks in resize.ts & fit.ts - #255

Open
jeth88 wants to merge 1 commit into
pixijs:mainfrom
jeth88:utils-safety-checks
Open

Improve safety checks in resize.ts & fit.ts#255
jeth88 wants to merge 1 commit into
pixijs:mainfrom
jeth88:utils-safety-checks

Conversation

@jeth88

@jeth88 jeth88 commented Apr 3, 2026

Copy link
Copy Markdown
  • Added guard condition for undefined view in resize.ts → centerView
  • Throw error when child is undefined in fit.ts → fitToView
  • Deferred assignment of child.scaleX/scaleY until all parameters are validated (related to the above change)

@jeth88
jeth88 marked this pull request as ready for review April 3, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zyie Zyie Awaiting requested review from Zyie Zyie is a code owner
@GoodBoyDigital GoodBoyDigital Awaiting requested review from GoodBoyDigital GoodBoyDigital is a code owner
@CyberDex CyberDex Awaiting requested review from CyberDex CyberDex is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeth88