Skip to content

Add remote certificate and certificate IDs - #3677

Open
fippo wants to merge 3 commits into
nextfrom
stats-certificates
Open

fippo wants to merge 3 commits into
nextfrom
stats-certificates

Conversation

@fippo

@fippo fippo commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Set localCertificateId and remoteCertificateId in transport stats. Report only the local certificate the DTLS transport uses and the remote certificate chain, linked via issuerCertificateId. Encode base64Certificate with standard base64.

Set localCertificateId and remoteCertificateId in transport stats.
Report only the local certificate the DTLS transport uses and the
remote certificate chain, linked via issuerCertificateId. Encode
base64Certificate with standard base64.
@fippo

fippo commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

(I hate putting a big blob into stats but putting the issuerId / their CN is even worse)

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.35%. Comparing base (ae155e3) to head (31e0185).
⚠️ Report is 21 commits behind head on next.

Files with missing lines Patch % Lines
certificate.go 84.61% 2 Missing ⚠️
dtlstransport.go 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3677      +/-   ##
==========================================
+ Coverage   90.81%   91.35%   +0.54%     
==========================================
  Files          81       67      -14     
  Lines        9348     7881    -1467     
==========================================
- Hits         8489     7200    -1289     
+ Misses        859      681     -178     
Flag Coverage Δ
go 91.35% <90.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant