[codex] Fix macOS helper bundle identities#2407
Conversation
Co-authored-by: codex <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Build-time configuration fix that ensures macOS Electron helper processes get correct bundle identifiers. Changes are limited to build scripts and packaging config, with no runtime behavior impact. Includes test coverage. You can customize Macroscope's approvability policy. Learn more. |
|
@bhavyamithal-jp can you confirm whether this fixes it |
Summary
Fixes #2405.
Restores T3 Code-specific macOS Electron helper identity so enterprise EDR tools can associate helper processes, especially the GPU helper, with the parent app instead of the default Electron identity.
Changes
com.t3tools.t3code.helper.*, includingcom.t3tools.t3code.helper.gpu.Info.plistpatching for launcher-created macOS bundles while keeping dev launches on the stock Electron path.Validation
bun fmtbun lint(passes with existing warnings outside this change)bun typecheckbun run --filter @t3tools/scripts test -- build-desktop-artifact.test.tsNote
Fix macOS Electron helper bundle identities in the desktop app build
MAC_HELPER_BUNDLE_IDSconstant inbuild-desktop-artifact.tsdefining explicit bundle IDs for all six Electron helper processes, rooted atcom.t3tools.t3code.macconfig increateBuildConfigso electron-builder sets them at package time.patchHelperBundleInfoPlistsinelectron-launcher.mjsto scanContents/FrameworksforElectron Helper*.appbundles and rewrite theirCFBundleDisplayName,CFBundleName, andCFBundleIdentifierto match the app's display name and bundle ID.LAUNCHER_VERSIONfrom 2 to 3 to trigger re-patching on existing installs.Macroscope summarized f760713.
Note
Medium Risk
Changes macOS packaging/launcher plist patching and bundle IDs, which can affect helper process launching and code signing/notarization behavior on macOS.
Overview
Ensures macOS Electron helper apps (including GPU/renderer/plugin helpers) use T3 Code-specific bundle identifiers instead of the default Electron identity.
This updates the production macOS launcher to also rewrite each
Electron Helper*.appInfo.plist(name +CFBundleIdentifier) and bumpsLAUNCHER_VERSIONto force regeneration. Separately, the desktop build script now hard-codes and appliesMAC_HELPER_BUNDLE_IDSin the mac electron-builder config and adds a regression test asserting these IDs are present.Reviewed by Cursor Bugbot for commit f760713. Bugbot is set up for automated code reviews on this repo. Configure here.