Skip to content

[codex] Fix macOS helper bundle identities#2407

Open
juliusmarminge wants to merge 1 commit intomainfrom
t3code/c171adfb
Open

[codex] Fix macOS helper bundle identities#2407
juliusmarminge wants to merge 1 commit intomainfrom
t3code/c171adfb

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 29, 2026

Summary

Fixes #2405.

Restores T3 Code-specific macOS Electron helper identity so enterprise EDR tools can associate helper processes, especially the GPU helper, with the parent app instead of the default Electron identity.

Changes

  • Explicitly configure electron-builder mac helper bundle IDs under com.t3tools.t3code.helper.*, including com.t3tools.t3code.helper.gpu.
  • Restore production launcher helper Info.plist patching for launcher-created macOS bundles while keeping dev launches on the stock Electron path.
  • Add a scripts regression test that verifies the mac build config pins helper bundle IDs.

Validation

  • bun fmt
  • bun lint (passes with existing warnings outside this change)
  • bun typecheck
  • bun run --filter @t3tools/scripts test -- build-desktop-artifact.test.ts

Note

Fix macOS Electron helper bundle identities in the desktop app build

  • Adds MAC_HELPER_BUNDLE_IDS constant in build-desktop-artifact.ts defining explicit bundle IDs for all six Electron helper processes, rooted at com.t3tools.t3code.
  • Spreads these IDs into the mac config in createBuildConfig so electron-builder sets them at package time.
  • Adds patchHelperBundleInfoPlists in electron-launcher.mjs to scan Contents/Frameworks for Electron Helper*.app bundles and rewrite their CFBundleDisplayName, CFBundleName, and CFBundleIdentifier to match the app's display name and bundle ID.
  • Bumps LAUNCHER_VERSION from 2 to 3 to trigger re-patching on existing installs.

Macroscope summarized f760713.


Note

Medium Risk
Changes macOS packaging/launcher plist patching and bundle IDs, which can affect helper process launching and code signing/notarization behavior on macOS.

Overview
Ensures macOS Electron helper apps (including GPU/renderer/plugin helpers) use T3 Code-specific bundle identifiers instead of the default Electron identity.

This updates the production macOS launcher to also rewrite each Electron Helper*.app Info.plist (name + CFBundleIdentifier) and bumps LAUNCHER_VERSION to force regeneration. Separately, the desktop build script now hard-codes and applies MAC_HELPER_BUNDLE_IDS in the mac electron-builder config and adds a regression test asserting these IDs are present.

Reviewed by Cursor Bugbot for commit f760713. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a5ea4bf1-706c-4c9c-9092-88c9c920ab99

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/c171adfb

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 29, 2026
@juliusmarminge juliusmarminge marked this pull request as ready for review April 29, 2026 23:56
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 30, 2026

Approvability

Verdict: Approved

Build-time configuration fix that ensures macOS Electron helper processes get correct bundle identifiers. Changes are limited to build scripts and packaging config, with no runtime behavior impact. Includes test coverage.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
Copy link
Copy Markdown
Member Author

@bhavyamithal-jp can you confirm whether this fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.0.21 breaks compatibility with enterprise EDR tools (Palo Alto Cortex XDR) — GPU helper process killed due to removed bundle ID patching

1 participant