keyspacepb: add load keyspace by ID RPC#1491
Merged
Merged
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
JmPotato
approved these changes
Jun 18, 2026
bufferflies
approved these changes
Jun 18, 2026
|
@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
niubell
approved these changes
Jun 22, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, JmPotato, niubell The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot Bot
pushed a commit
to tikv/pd
that referenced
this pull request
Jun 23, 2026
ref #10912\n\nAdd a LoadKeyspaceByID gRPC handler that loads keyspace metadata by ID and applies the same region-bound readiness check as LoadKeyspace. Expose LoadKeyspaceByID on the Go PD client with request metrics, and add unit coverage for successful responses and header errors. Update kvproto to the merged pingcap/kvproto#1491 version for the new RPC definition.\n\nSigned-off-by: Ryan Leung <rleungx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed
Add LoadKeyspaceByID to the keyspace service and introduce LoadKeyspaceByIDRequest carrying the target keyspace ID.
Generated Go bindings and proto.lock are updated for the new RPC.
Tests
Verified through the dependent PD integration test: