Filter by Git Status & Responsive fixes

[mdo]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
pierre-docs-diffs	Ready	Preview	Jun 12, 2026 8:56pm
pierre-docs-diffshub	Ready	Preview	Jun 12, 2026 8:56pm
pierre-docs-trees	Ready	Preview	Jun 12, 2026 8:56pm
pierrejs-diff-demo	Ready	Preview	Jun 12, 2026 8:56pm
pierrejs-docs	Ready	Preview	Jun 12, 2026 8:56pm

[chatgpt-codex-connector]

💡 Codex Review

pierre/packages/diffs/src/components/CodeView.ts

Line 656 in 92e5e3f

window.__INSTANCE = this;

Remove global debug hooks from CodeView setup

Avoid assigning window.__INSTANCE/window.__TOGGLE during normal setup() because these hooks run in all builds and keep a strong reference to the viewer instance after mount. In long-lived docs sessions (or repeated mounts/unmounts), this can leak memory and also lets unrelated page scripts mutate the active viewer state through those globals.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[amadeus]

@mdo do we still want to get this merged?

[mdo]

@mdo do we still want to get this merged?

@amadeus I just rebased might, need to clean up more. After that I think I still need to play with a little of the UI and logic here to feel out if the flow is right. Last we talked, we maybe discussed reversing the behavior of the menu items there now. Curious to see what @necolas thinks if he has time to look though too.

[necolas]

The git status popover doesn't match the active shiki theme.
My initial thought upon seeing the tick mark over the status symbol was that it was bugged

wonder if it might be better to put the check state symbol on the right like it is on the themes popover

[mdo]

Ya that's a bug from the rebase. It'd be on the right. I can also look into how to match it's theme, too.

[necolas]

These icons dont have hover/focus states for light themes

Happy for this to be merged though