Skip to content

fix: don't checkout in generate-tool-inventory#1377

Merged
Ron (rjaegers) merged 3 commits into
mainfrom
fix/remove-checkout-from-generate-tool-inventory
Jul 22, 2026
Merged

fix: don't checkout in generate-tool-inventory#1377
Ron (rjaegers) merged 3 commits into
mainfrom
fix/remove-checkout-from-generate-tool-inventory

Conversation

@rjaegers

Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates the way the allowlist file is handled in the generate-tool-inventory GitHub Action and its usage in the workflow. The main change is moving the responsibility for checking out the allowlist/tool-inventory file from the action itself to the workflow, resulting in a simpler and more flexible action.

Workflow and Action Refactoring:

  • The action no longer checks out the allowlist file internally; instead, the workflow checks out the file when needed. This makes the action more reusable and avoids redundant checkouts. [1] [2]
  • The ALLOWLIST environment variable in the action now directly references the input path, since the workflow ensures the file is present.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM
  • I understand the image size delta and agree the functionality justifies it

Copilot AI review requested due to automatic review settings July 22, 2026 09:26
@rjaegers
Ron (rjaegers) requested a review from a team as a code owner July 22, 2026 09:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the generate-tool-inventory composite GitHub Action to stop performing its own repository checkout, and instead moves responsibility for making the allowlist/tool-inventory file available to the calling workflow, improving action reusability and avoiding redundant checkouts.

Changes:

  • Removed the internal actions/checkout step from the generate-tool-inventory composite action and updated it to use the input path directly for ALLOWLIST.
  • Updated the reusable build/push workflow to conditionally checkout only the requested tool inventory allowlist file (via sparse checkout) before running the action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/wc-build-push.yml Adds a conditional sparse checkout step so the allowlist file exists before invoking the tool-inventory action.
.github/actions/generate-tool-inventory/action.yml Removes internal checkout logic and switches ALLOWLIST to reference the provided input path directly.

Comment thread .github/actions/generate-tool-inventory/action.yml
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.7s
✅ DOCKERFILE hadolint 4 0 0 0.46s
✅ JSON npm-package-json-lint yes no no 0.54s
✅ JSON prettier 44 6 0 0 0.78s
✅ JSON v8r 44 0 0 18.08s
✅ MARKDOWN markdownlint 13 0 0 0 1.3s
✅ MARKDOWN markdown-table-formatter 13 0 0 0 0.28s
✅ REPOSITORY betterleaks yes no no 1.6s
✅ REPOSITORY checkov yes no no 28.49s
✅ REPOSITORY gitleaks yes no no 1.9s
✅ REPOSITORY git_diff yes no no 0.02s
✅ REPOSITORY grype yes no no 70.49s
⚠️ REPOSITORY osv-scanner yes 1 no 1.03s
✅ REPOSITORY secretlint yes no no 2.31s
✅ REPOSITORY syft yes no no 2.94s
✅ REPOSITORY trivy yes no no 12.5s
✅ REPOSITORY trivy-sbom yes no no 2.11s
✅ REPOSITORY trufflehog yes no no 4.09s
⚠️ SPELL lychee 115 1 0 11.43s
✅ YAML prettier 35 0 0 0 1.35s
✅ YAML v8r 35 0 0 15.88s
✅ YAML yamllint 35 0 0 1.45s

Detailed Issues

⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........154
🔗 Unique.........126
✅ Successful.....148
⏳ Timeouts.........0
🔀 Redirected......19
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (at 38:7) | Rejected status code: 403 Forbidden

Hint: Followed 19 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned .devcontainer/cpp/requirements.txt file and found 20 packages
Scanned .devcontainer/docs/requirements.txt file and found 14 packages
Scanned test/embedded-rust/workspace/cortex-m/Cargo.lock file and found 20 packages
Scanned test/embedded-rust/workspace/cortex-mf/Cargo.lock file and found 20 packages
Scanned test/rust/workspace/cargo/Cargo.lock file and found 1 package
Scanned test/rust/workspace/clippy/Cargo.lock file and found 1 package
Scanned test/rust/workspace/test/Cargo.lock file and found 1 package
Scanned package-lock.json file and found 73 packages
End status: 105 dirs visited, 341 inodes visited, 8 Extract calls, 21.295215ms elapsed, 21.295446ms wall time

Total 2 packages affected by 2 known vulnerabilities (0 Critical, 0 High, 0 Medium, 0 Low, 2 Unknown) from 1 ecosystem.
0 vulnerabilities can be fixed.

+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+
| OSV URL                           | CVSS | ECOSYSTEM | PACKAGE    | VERSION | FIXED VERSION | SOURCE                                            |
+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/embedded-rust/workspace/cortex-m/Cargo.lock  |
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/embedded-rust/workspace/cortex-mf/Cargo.lock |
+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1377

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 75.35 MB 75.35 MB 139 B (0%) 🔽
linux/arm64 73.43 MB 73.43 MB 178 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-docs:edgeghcr.io/philips-software/amp-devcontainer-docs:pr-1377

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 200.14 MB 200.14 MB 310 B (0%) 🔽
linux/arm64 196.35 MB 196.35 MB +155 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1377

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 406.07 MB 406.07 MB 41 B (0%) 🔽
linux/arm64 357.64 MB 357.64 MB 293 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-cpp:edgeghcr.io/philips-software/amp-devcontainer-embedded-cpp:pr-1377

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 560.5 MB 560.5 MB +2.23 kB (+0%) 🔼
linux/arm64 538.95 MB 538.95 MB 336 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-rust:edgeghcr.io/philips-software/amp-devcontainer-embedded-rust:pr-1377

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 468.96 MB 468.96 MB 233 B (0%) 🔽
linux/arm64 419.91 MB 419.91 MB 267 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1377

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 372.13 MB 372.13 MB +380 B (+0%) 🔼
linux/arm64 352.26 MB 352.26 MB +199 B (+0%) 🔼

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 22, 2026 09:39 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Test Results

 25 files  ±0   25 suites  ±0   18m 57s ⏱️ + 1m 57s
 48 tests ±0   48 ✅ ±0  0 💤 ±0  0 ❌ ±0 
201 runs  ±0  201 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0fc50a0. ± Comparison against base commit 3f6a8f2.

♻️ This comment has been updated with latest results.

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 22, 2026 10:20 — with GitHub Actions Inactive
@sonarqubecloud

Copy link
Copy Markdown

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 22, 2026 11:15 — with GitHub Actions Inactive
@rjaegers
Ron (rjaegers) added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 2582be9 Jul 22, 2026
91 checks passed
@rjaegers
Ron (rjaegers) deleted the fix/remove-checkout-from-generate-tool-inventory branch July 22, 2026 11:44
@github-actions

Copy link
Copy Markdown
Contributor

Pull Request Report (#1377)

Static measures

Description Value
Number of added lines 8
Number of deleted lines 10
Number of changed files 2
Number of commits 3
Number of reviews 2
Number of comments (w/o review comments) 9
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.3 Hours
Time that was spend on the branch before the PR was created 25 Sec
Time that was spend on the branch before the PR was merged 2.3 Hours
Time to merge after last review 2.1 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 1.7 Hours
Total time spend in last status check run on PR 22 Min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants