Repository navigation
ref: use phel 0.54 core helpers and add a mutation gate for core - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Use what phel 0.54 (the latest stable release) already ships instead of hand-rolled equivalents, and gate the pure core with mutation testing.
🔖 Changes
int?replacesphp/is_int, andphel.string/joinreplacesimplodeover a converted array.parse-intinstead of switching to coreparse-long:parse-longclamps9223372036854775808to the maximum integer, which brings back the silent wrong answer fixed earlier. A one-line comment says so.composer mutate(alsomake mutate) runsphel mutate src/corewith a 90% floor. It runs insidecomposer ciand as a CI step. The core scores 100% today (12 of 12 mutants killed).Not adopted
1.0.0-rc2 is a pre-release, so the skeleton stays on
^0.54.Verification
composer cipasses: format, lint, 36 tests, mutation 100%, build, export.add 1 abc xprintsNot an integer: abc, xand exits 1, as before.