Repository navigation
ref: keep add decisions in core and extract command registration - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Two quality fixes after the recent bug fixes. No behavior change.
🔖 Changes
addkept domain decisions in the command: it parsed every token twice and checked integer overflow itself. These now live in the puresum-tokensincore/adder, which returns the total, the bad tokens, or an overflow flag. The command only prints.bin/register-command, a small PHP script with named parts, andbin/new-commandcalls it.Verification
composer checkpasses (48 assertions, up from 36 with newsum-tokensunit tests).addoutput and exit codes are the same for bad input, overflow,-- -1 2and a plain sum.say-hi,hi,tandderregister in order; a repeated name, an oddly shaped file and a read-only file print the manual steps and exit 0.shellcheck bin/new-commandandphp -l bin/register-commandare clean.