[Method Browser] Proposing to save changes for dirty methods#1383
Open
AlexisCnockaert wants to merge 1 commit intopharo-spec:Pharo14from
Open
[Method Browser] Proposing to save changes for dirty methods#1383AlexisCnockaert wants to merge 1 commit intopharo-spec:Pharo14from
AlexisCnockaert wants to merge 1 commit intopharo-spec:Pharo14from
Conversation
This code will work when all the `SpCodePresenter` stuff will be able to handle it tho, I just prepared the ground. And as Esteban said: "My intention is to create a meta-code-presenter (SpPharoEditorPresenter) that will handle all higher level stuff that can be modeled composing presenters", I will not propose a quick solution, his idea is way better. Since he has a prototype, I think we can wait. Fixes #19553
Contributor
|
Tx for the notice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code will work when all the
SpCodePresenterstuff will be able to handle it, for now it don't understand when a method is dirty. I just prepared the ground.However as Esteban said: "My intention is to create a meta-code-presenter (SpPharoEditorPresenter) that will handle all higher level stuff that can be modeled composing presenters", I will not propose a quick solution here, his idea is way better.
Since he has a prototype, I think we can wait.
Fixes #19553