Support multiple cargo pgrx test filters#2345
Open
eeeebbbbrrrr wants to merge 1 commit into
Open
Conversation
Allow cargo pgrx test to accept multiple trailing test-name filters, matching the way agents and users naturally invoke commands like:
cargo pgrx test --package xyz pg18 test_a test_b test_n
Previously clap accepted only one TESTNAME positional, so additional filters failed during CLI parsing with an unexpected argument error before cargo-pgrx could run tests.
This changes the test command to collect TESTNAME... positionals, preserve the existing optional leading pgXX/all selector behavior, and forward filters to libtest after -- as substring filters:
cargo test ... -- test_a test_b test_n
That keeps a single cargo test invocation per selected PostgreSQL version and uses libtest's native multi-filter support instead of fanning out repeated cargo invocations or treating the filters as a regex.
The README help snippet now documents TESTNAME..., and focused unit coverage verifies parsing, non-version shorthand handling, pg selector handling, and the generated cargo test argv shape.
Verified with:
cargo test -p cargo-pgrx command::test
cargo run -p cargo-pgrx -- pgrx test --help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow cargo pgrx test to accept multiple trailing test-name filters, matching the way agents and users naturally invoke commands like:
Previously clap accepted only one TESTNAME positional, so additional filters failed during CLI parsing with an unexpected argument error before cargo-pgrx could run tests.
This changes the test command to collect TESTNAME... positionals, preserve the existing optional leading pgXX/all selector behavior, and forward filters to libtest after -- as substring filters:
That keeps a single cargo test invocation per selected PostgreSQL version and uses libtest's native multi-filter support instead of fanning out repeated cargo invocations or treating the filters as a regex.
The README help snippet now documents TESTNAME..., and focused unit coverage verifies parsing, non-version shorthand handling, pg selector handling, and the generated cargo test argv shape.