Fix Docker build: use npm install instead of npm ci - #117
Merged
Conversation
npm ci fails with npm overrides (torrent-stream ws/ip overrides) in npm 10 — same fix as the CI workflow. Generated with Claude Code
There was a problem hiding this comment.
Pull request overview
This PR fixes the addon container build by switching the dependency installation step in addon/Dockerfile from npm ci to npm install, aligning the Docker build behavior with the earlier CI workflow adjustment referenced in PR #116 (to avoid npm ci failures in npm 10 when overrides are present).
Changes:
- Replace
npm ci --omit=devwithnpm install --omit=devin the addon Dockerfile to avoid npm 10 override-relatednpm cifailures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm ciwithnpm installin the addon Dockerfilenpm cifails with npm overrides (torrent-stream ws/ip overrides) in npm 10 — same issue that was fixed in the CI workflow in PR Add P2P privacy proxy, per-user VPN, speed optimizations, and reliability #116The deploy from #116 failed because the Dockerfile still used
npm ci.Generated with Claude Code