Skip to content

Fix parent page inventory validation for 0.5.2 - #5

Merged
peterbussch merged 1 commit into
mainfrom
fix/classification-parent-inventory
Sep 12, 2026
Merged

peterbussch merged 1 commit into
mainfrom
fix/classification-parent-inventory

Conversation

@peterbussch

@peterbussch peterbussch commented Sep 12, 2026 •

Copy link
Copy Markdown
Owner

classify --from-run could accept a truncated parent route map or invalid page identities. It now checks every document against the manifest before reading raw evidence or calling a classifier hook, so invalid parents cannot produce a partial classification.

This addresses both Copilot findings on #4:

Valid reversed page ordering, relative input paths, and missing raw evidence remain supported. Regression tests check rejection, unchanged parent files, no output writes, and a valid multi-document round trip. Package metadata and active examples advance to 0.5.2; historical validation records and artifact format versions remain unchanged.

The agent guide now makes GitHub-native features and Copilot guidance a standing repository practice. Release instructions require reading review threads before merge and again before publication.

Validation:

  • Full local suite: 1,193 passed, no skips.
  • Independent review: no actionable findings; 51 focused tests passed.
  • Ruff lint/format, mypy, release metadata, and lock checks passed.
  • Exact wheel and sdist: build, Twine, archive inventories, and both maintained first-run tutorials passed in isolated environments outside the checkout.

Copilot review was requested on this commit. Both its automatic and explicit review attempts returned an account quota-limit notice without reviewing code. Its two earlier findings are addressed here and linked in the original review threads. Independent review is the available review evidence; GitHub CI must also pass before merge. The review threads will be checked again before publication.

Copilot AI lite review requested due to automatic review settings September 12, 2026 16:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@peterbussch
peterbussch requested a lite review from Copilot September 12, 2026 16:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@peterbussch
peterbussch merged commit e211d9d into main Sep 12, 2026
13 checks passed
@peterbussch
peterbussch deleted the fix/classification-parent-inventory branch September 25, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants