Repository navigation
Fix parent page inventory validation for 0.5.2 - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classify --from-runcould accept a truncated parent route map or invalid page identities. It now checks every document against the manifest before reading raw evidence or calling a classifier hook, so invalid parents cannot produce a partial classification.This addresses both Copilot findings on #4:
Valid reversed page ordering, relative input paths, and missing raw evidence remain supported. Regression tests check rejection, unchanged parent files, no output writes, and a valid multi-document round trip. Package metadata and active examples advance to 0.5.2; historical validation records and artifact format versions remain unchanged.
The agent guide now makes GitHub-native features and Copilot guidance a standing repository practice. Release instructions require reading review threads before merge and again before publication.
Validation:
Copilot review was requested on this commit. Both its automatic and explicit review attempts returned an account quota-limit notice without reviewing code. Its two earlier findings are addressed here and linked in the original review threads. Independent review is the available review evidence; GitHub CI must also pass before merge. The review threads will be checked again before publication.