Revert "Move code from ExecutorCheckPerms into ExecutorStart" - #804
Merged
Conversation
This reverts commit 015df29. As Zsolt pointed out this commit which was intended as a refactoring turned out to accidentally fix some bugs while also introducing new ones. This kind of random behavioral changes is bad for our users. We should in the future come back to this and fix it for real but for now we jsut revert the code.
jeltz
force-pushed
the
revert-mv-relation-code
branch
from
July 26, 2026 12:44
afd3e86 to
4001e9d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 88.12% 88.17% +0.04%
==========================================
Files 3 3
Lines 1297 1302 +5
Branches 180 181 +1
==========================================
+ Hits 1143 1148 +5
Misses 76 76
Partials 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
artemgavrilov
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 015df29.
As Zsolt pointed out this commit which was intended as a refactoring turned out to accidentally fix some bugs while also introducing new ones. This kind of random behavioral changes is bad for our users. We should in the future come back to this and fix it for real but for now we just revert the code.
PG-0