Repository navigation
prevent Nexuses from writing old RackNetworkConfig configs - #11604
Open
nicolaskagami wants to merge 2 commits into
Open
nicolaskagami wants to merge 2 commits into
nicolaskagami wants to merge 2 commits into
Conversation
RackNetworkConfig configs
nicolaskagami
marked this pull request as ready for review
October 27, 2026 19:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10855
Context
Currently, two nexuses can race to write to the bootstore and an older configuration of
RackNetworkConfigcan be written atop a new one. This can be solved with a minimal tweak of how we use the bootstore generation number. If we guarantee that:Then a newer write must have observed a newer config.
What does this PR change?
RackNetworkConfigInput.Details
mainwrote older configs 19/78 times while this branch never did.