Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

fix(password-protected-folders): [OCISDEV-1016] validate .psec URL before opening - #13925

Merged
mzner merged 1 commit into
stable-12.4from
chore/backport-validate-psec-url
Jun 30, 2026
Merged

mzner merged 1 commit into
stable-12.4from
chore/backport-validate-psec-url

Conversation

@mzner

@mzner mzner commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

backport validate .psec URL before opening

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Open tasks:

  • ...

@mzner
mzner requested a review from LukasHirt June 30, 2026 18:28
@kw-security

kw-security commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud

Copy link
Copy Markdown

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of #13924 (merged to master) onto stable-12.4 — keep both. Not a duplicate/mis-base: #13924 is the canonical fix, #13925 is its release-branch backport. Diff is byte-identical (150/12, same code + same changelog fragment).

Security logic checks out:

  • Scheme allowlist (https:/http:) blocks javascript:/data:/blob: from a tampered .psec.
  • Origin pinned to configStore.serverUrl, validated at both open and create time.
  • iframe sandbox is sound defense-in-depth. No bypass apparent.

Changelog: present and valid; references PR #13924 — correct canonical ref for a backport.

Tests: cover scheme-bypass vectors + cross-origin on both open and create paths. Adequate.

CI: build still pending; everything else green. No concerns from review.

🤖 Generated with Claude Code

@mzner
mzner merged commit d50cd1c into stable-12.4 Jun 30, 2026
20 checks passed
@mzner
mzner deleted the chore/backport-validate-psec-url branch June 30, 2026 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants