Repository navigation
fix(password-protected-folders): [OCISDEV-1016] validate .psec URL before opening - #13925
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
DeepDiver1975
left a comment
There was a problem hiding this comment.
Faithful backport of #13924 (merged to master) onto stable-12.4 — keep both. Not a duplicate/mis-base: #13924 is the canonical fix, #13925 is its release-branch backport. Diff is byte-identical (150/12, same code + same changelog fragment).
Security logic checks out:
- Scheme allowlist (
https:/http:) blocksjavascript:/data:/blob:from a tampered.psec. - Origin pinned to
configStore.serverUrl, validated at both open and create time. - iframe
sandboxis sound defense-in-depth. No bypass apparent.
Changelog: present and valid; references PR #13924 — correct canonical ref for a backport.
Tests: cover scheme-bypass vectors + cross-origin on both open and create paths. Adequate.
CI: build still pending; everything else green. No concerns from review.
🤖 Generated with Claude Code



backport validate .psec URL before opening
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Open tasks: