Repository navigation
[full-ci][tests-only]tests: Vault Resource Isolation - #13922
kavitagautam wants to merge 2 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
DeepDiver1975
left a comment
There was a problem hiding this comment.
Verdict: changes requested. CI is red and the resource-isolation test as written cannot pass.
CI (build / build) fails at Check format (prettier); check-tests-passed is consequently red, e2e skipped. The diff has missing trailing newlines (steps/ui/index.ts, vault.spec.ts, etc.) and trailing whitespace (e.g. the blank line in the Resource Isolation beforeEach, the }) after the isolation test). Run pnpm format / prettier and push.
Resource Isolation test can't pass as written — tests/e2e/specs/vault-mode/vault.spec.ts:
beforeEachcreatesdrive/drive.txt, but the test asserts ondrive-file.txt/vault-file.txt— names don't match the created file.userHasCreatedVaultFiles(... vault/vault.txt ...)is commented out, sovault-file.txtis never created;userShouldSeeResources(['vault-file.txt'])in Vault mode will fail.- Net: the test that proves AC-3 (the PR's point) is not actually exercising isolation. Either finish the vault-file setup and align the filenames, or split it out until the
userHasCreatedVaultFilesstep exists.
The mode-switch test, the VaultPage POM, and generateOtpFromScreenshot (jimp is already a dep) look consistent with existing conventions; the issue is scoped to the isolation case + formatting.
🤖 Generated with Claude Code
edb25f5 to
38ae949
Compare
|
|
Web repo is going to be archived and will no longer accept new PRs. Please, use owncloud/ocis repository instead. |



Description
This PR adds test for vault resource isolation.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Open tasks: