Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

[full-ci][tests-only]tests: Vault Resource Isolation - #13922

Closed
kavitagautam wants to merge 2 commits into
masterfrom
test/vault-resource-isolation
Closed

kavitagautam wants to merge 2 commits into
masterfrom
test/vault-resource-isolation

Conversation

@kavitagautam

Copy link
Copy Markdown
Contributor

Description

This PR adds test for vault resource isolation.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Open tasks:

  • ...

@kavitagautam kavitagautam self-assigned this Jun 30, 2026
@kw-security

kw-security commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested. CI is red and the resource-isolation test as written cannot pass.

CI (build / build) fails at Check format (prettier); check-tests-passed is consequently red, e2e skipped. The diff has missing trailing newlines (steps/ui/index.ts, vault.spec.ts, etc.) and trailing whitespace (e.g. the blank line in the Resource Isolation beforeEach, the }) after the isolation test). Run pnpm format / prettier and push.

Resource Isolation test can't pass as written — tests/e2e/specs/vault-mode/vault.spec.ts:

  • beforeEach creates drive/drive.txt, but the test asserts on drive-file.txt / vault-file.txt — names don't match the created file.
  • userHasCreatedVaultFiles(... vault/vault.txt ...) is commented out, so vault-file.txt is never created; userShouldSeeResources(['vault-file.txt']) in Vault mode will fail.
  • Net: the test that proves AC-3 (the PR's point) is not actually exercising isolation. Either finish the vault-file setup and align the filenames, or split it out until the userHasCreatedVaultFiles step exists.

The mode-switch test, the VaultPage POM, and generateOtpFromScreenshot (jimp is already a dep) look consistent with existing conventions; the issue is scoped to the isolation case + formatting.

🤖 Generated with Claude Code

@kavitagautam
kavitagautam marked this pull request as draft June 30, 2026 06:36
@kavitagautam
kavitagautam force-pushed the test/vault-resource-isolation branch from edb25f5 to 38ae949 Compare June 30, 2026 12:31
@sonarqubecloud

Copy link
Copy Markdown

@LukasHirt

Copy link
Copy Markdown
Collaborator

Web repo is going to be archived and will no longer accept new PRs. Please, use owncloud/ocis repository instead.

@LukasHirt LukasHirt closed this Jul 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants