Skip to content

chore: remove final parameters log on resource creation #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandrevilain wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove final parameters log on resource creation #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions internal/services/cloud/cloud_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,14 +561,6 @@ func ReinstallInstance(cmd *cobra.Command, args []string) {
return
}

out, err := json.MarshalIndent(parameters, "", " ")
if err != nil {
display.OutputError(&flags.OutputFormatConfig, "installation parameters cannot be marshalled: %s", err)
return
}

log.Println("Installation parameters: \n" + string(out))

var task map[string]any
endpoint := fmt.Sprintf("/v1/cloud/project/%s/instance/%s/reinstall", projectID, url.PathEscape(args[0]))
if err := httpLib.Client.Post(endpoint, parameters, &task); err != nil {
Expand Down
8 changes: 0 additions & 8 deletions internal/services/cloud/cloud_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,6 @@ func CreateUserS3Policy(cmd *cobra.Command, args []string) {
return
}

out, err := json.MarshalIndent(parameters, "", " ")
if err != nil {
display.OutputError(&flags.OutputFormatConfig, "parameters cannot be marshalled: %s", err)
return
}

log.Println("Final parameters: \n" + string(out))

endpoint := fmt.Sprintf("/v1/cloud/project/%s/user/%s/policy", projectID, url.PathEscape(args[0]))
if err := httpLib.Client.Post(endpoint, parameters, nil); err != nil {
display.OutputError(&flags.OutputFormatConfig, "error creating resource: %s", err)
Expand Down
7 changes: 0 additions & 7 deletions internal/services/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,6 @@ func CreateResource(cmd *cobra.Command, path, endpoint, defaultExample string,
}
}

out, err := json.MarshalIndent(parameters, "", " ")
if err != nil {
return nil, fmt.Errorf("parameters cannot be marshalled: %w", err)
}

log.Println("Final parameters: \n" + string(out))

var createdResource map[string]any
if err := httpLib.Client.Post(endpoint, parameters, &createdResource); err != nil {
return nil, fmt.Errorf("error creating resource: %w", err)
Expand Down
Loading