Skip to content

Fix Stack_overflow for filtering a file - #102

Open
westpaddy wants to merge 1 commit into
ott-lang:masterfrom
westpaddy:fix-stackoverflow
Open

westpaddy wants to merge 1 commit into
ott-lang:masterfrom
westpaddy:fix-stackoverflow

Conversation

@westpaddy

Copy link
Copy Markdown

The current implementation rarely raises the Stack_overflow exception for filtering some particular files. I encountered the situation with a file containing a rather long [[ ... ]] being parsed.

This fix replaces non-tail-recursive functions related to the problem with tail-recursive ones. I believe this fix causes minor performance issues for at least filtering files the current implementation can handle because only a short list is dealt with in such cases. The fix may be more efficient if we well understand the algorithm, though. For example, we can remove List.rev if a list used in the algorithm is order-irrespective.

@palmskog palmskog added the v0.35 label Sep 16, 2026
@palmskog palmskog assigned palmskog and unassigned palmskog Sep 16, 2026
@palmskog
palmskog self-requested a review September 16, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants