fixed basic html issues and improved responsiveness - #7
Open
iconic-asf2910 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--WHAT I FIXED--
1- the html was missing the viewport meta tag which causes layout issues on mobile phones.
So i added the viewport meta tag.
2- the contact section didnt have a matching id so clicking it didnt do anything.
Added a id="contact" so the anchor link works properly.
3- the button type wasnt defined. Added the type="sumbit" to the submit button.
4-the layout of cards in the feature section was fixed so on smaller screens they werent adjusting properly.Updated the layout so they fix propely.
5-The navbar was overlapping the page content cause it was fixed at the top.Added spacing at the top and adjusted the navbar so content appears properly.