Repository navigation
feat(ui): use the primary button of the design system in the card sheets - #767
Merged
Merged
Conversation
The add button of the create card and extra field sheets is the primary button: a 44 tall glass capsule on iOS, a 40 tall filled pill on Android. The delete buttons of the card edit sheet use the error color. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A shared sheet header: iOS has a glass Cancel pill, the centered title and a prominent action; Android a close icon, the title and a text action. The create card, extra field and card edit sheets use it, so their add button leaves the bottom of the sheet, and the color of a new card moves to its own row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…orm ifs The sheet header shares its markup between platforms (buttons props picked in the script, title styled by css). The create card and extra field sheets are a grouped form of rows (label left, value right), each a ListItemAutoSize, like the edit sheet of the design. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
farfromrefug
marked this pull request as ready for review
October 29, 2026 09:34
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… disabled add readable The create card and extra field sheets keep the header of the design system and use the outlined fields again, the color of a new card is a row of its own on both platforms. The primary action is 45% when disabled and keeps its on-accent text color, so it is no longer red over red on iOS. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The outlined fields take the accent while they have the focus: a css pseudo class set from the focus and blur events on iOS, the stroke colors of the text field on Android. The sheets with fields resize with the keyboard on Android, so the focused field stays visible. The color row has the height of a field. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
feat(ui): give the card sheets the header of the design system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prominentGlasson iOS,containedon Android) for the add button of the create card and the extra field sheets, with the heights of the design system (44 iOS, 40 Android). The same variants already power Save in the card edit sheet.Deviations from the mockup (on purpose):
Selectbutton of the color picker and the other buttons of the sharedtoolssubmodule are not touched here.Testing
🤖 Generated with Claude Code