Repository navigation
[FSSDK-13238] ci: validate release PRs and allow manual release retries - #664
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlon PRs that changeSources/Utils/SDKVersion.swift, in validate-only mode: the version format must be valid andCHANGELOG.mdmust have a## <version>section. It exits before tagging or publishing.workflow_dispatchtrigger so a failed release can be retried from Actions → Release → Run workflow. A manual run reads the branch's latest commit, which picks up any fixes merged after the failure.masterandrelease/**, so nobody can publish a release from a feature branch.While testing on a fork, a release PR that was merged without its CHANGELOG section failed the release job. Re-running didn't help, because re-runs check out the original commit (
GITHUB_SHA). Merging a CHANGELOG fix didn't trigger the job either, because of theSDKVersion.swiftpath filter. The only way out was a manualgh release create. With this change, a PR missing its CHANGELOG section fails before merge, and transient failures can be retried from the UI.On
pull_request, the job still declarescontents: write. PRs from forks get a read-only token anyway, and same-repo branches come from people who already have write access.Test plan
actionlintpasses.v5.5.1. A bump without one failed, and re-running kept failing (the case this PR fixes).publishcheck, a PR with one passes ("ready to release"), and a manual run onmasterfor an existing tag prints "already released".Issues
🤖 Generated with Claude Code