Repository navigation
[FSSDK-13238] ci: publish releases automatically when SDKVersion.swift changes - #659
Merged
Merged
Conversation
Replace the manual PREP/RELEASE workflow_dispatch jobs (hub-based run_prep.sh / run_release.sh on macOS runners) with release.yml, which tags vX.Y.Z and publishes the GitHub release on merge to master or release/**. SDKVersion.swift is the single source of the version. Also run unit tests for release/** PRs; run_unit_tests.sh previously skipped them silently on any branch other than master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ci-helper-tools trigger script rejects workflow_dispatch events; the removed PREP/RELEASE guards used to skip this job on manual runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The only versioned line was the CocoaPods install snippet, removed in #658. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manual PREP/RELEASE
workflow_dispatchjobs (hubscripts on macOS runners, version inswift.yml) with a release that publishes on merge.SDKVersion.swiftis the single source of the version — it's what the SDK reports at runtime (client_version,OptimizelyClient.version), so the tag can't drift from it.swift.yml:VERSIONenv, per-jobif:guards and the two release jobsrelease/**toointegration_testson manual runs (the ci-helper-tools trigger script rejectsworkflow_dispatch; the old guards used to skip it)run_unit_tests.sh: remove theBRANCH == masterguard, which made unit tests report success without running on any other branch.run_prep.sh,run_release.sh,update_version.sh,build_all.sh(only used by prep).CLAUDE.mdrelease process: 2 files to bump,release/X.Y.xpatch flow, what happens after mergeSDKVersion.swiftandCHANGELOG.md; README no longer has a version since the CocoaPods line was removed in [FSSDK-11920] Migrate Swift SDK distribution, CI, and releases to SPM on Xcode 27 #658SDKVersion.swiftcommentTest plan
Publish script run locally against the repo:
tag exists -> skip## 5.5.0→ 8 lines,## 5.4.2→ 9 lines,## 9.9.9→ 0 lines (job fails)actionlintclean onrelease.yml.GITHUB_TOKENfrom creatingv*tags. The only rulesets are branch rules (force-push, Arnica).Merge Danger
Door: two-way. Reverting restores the old jobs and scripts. Once immutable releases are enabled, a published tag can't be moved or reused.
Blast Radius:
SDKVersion.swiftonmaster/release/**now publishes a release.release/**(previously skipped).release/**, immutable releases.Issues
🤖 Generated with Claude Code