Firewall: Rules [new]: Fix action, ipprotocol and protocol translations (legacy rules). Fix Automatically generated rules category (legacy rules).#10299
Open
Monviech wants to merge 3 commits into
Conversation
…ns. Fix Automatically generated rules category.
Monviech
changed the title
fichtner
reviewed
May 13, 2026
fichtner
reviewed
May 13, 2026
| 'inet' => gettext('IPv4'), | ||
| 'inet6' => gettext('IPv6'), | ||
| 'inet46' => '', /* XXX remove when filter.lib.inc use is removed */ | ||
| 'inet46' => gettext('IPv4+IPv6'), /* XXX remove when filter.lib.inc use is removed */ |
Member
There was a problem hiding this comment.
this was so "*" is displayed, which is a bit cleaner than cluttering IPv4+IPv6
Member
Author
There was a problem hiding this comment.
But then it's not the same as the MVC rules display inet46:
Member
There was a problem hiding this comment.
it doesn't have to be. inet46 is an atrocity
fichtner
reviewed
May 13, 2026
fichtner
reviewed
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Related issue
Fixes: #10249