Repository navigation
Conversation
71891af to
84ea266
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 81.66% 81.86% +0.20%
==========================================
Files 86 87 +1
Lines 6135 6205 +70
Branches 781 791 +10
==========================================
+ Hits 5010 5080 +70
Misses 892 892
Partials 233 233 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7a463b9 to
51d9c9d
Compare
51d9c9d to
edb928a
Compare
|
@pawank925 no need to ping me that much, if I don't reply it is only that I'm off or working on something more urgent I'll park this PR aside because it misses the whole architecture solution ; I think it is mostly OK from CMS perspective but since I still don't know what the overall architecture will be, it is hard to confirm. What I miss:
In the mean time @pawank925 would you mind to share screenshots of the demo page? |
|
@benoit74 really so sorry — I'll stop chasing and wait for you. Screenshots below. They come from this PR's own One row per name+flavour, keeping only the latest published book, and there is no limit or pagination — a client with 80 titles gets 80 rows. Details is This one is a defect in the PR, not in the data: at a 414px viewport the table measures 710px ( Browse is per-collection, so a collection without On your three points, from the CMS side only:
No action needed from you now — leaving it open and parked until the overall shape is decided. |



Closes #541.
Adds a server-rendered HTML demo page for the latest books in a collection (for client demos), following the access-control/data patterns of
catalog.xml/opds.xml.GET/HEAD /v1/collections/{collection_id_or_name}/demo.htmlwith ETag supportbackend/src/cms_backend/utils/demo_page.pybuilds a self-contained HTML page with Download/Browse linksbackend/tests/api/routes/test_collection_demo.pyadds route tests (OPDS-style pattern)I verified Python syntax; I couldn't run the full backend DB-backed test suite locally, but tests follow existing fixtures/patterns. Access control matches catalog/OPDS; happy to adjust (e.g. public/shareable access) per maintainer feedback.