Skip to content

remove letter suffix from release tags - #631

Merged
elfkuzco merged 1 commit into
mainfrom
remove-suffix-from-tag
Nov 3, 2026
Merged

elfkuzco merged 1 commit into
mainfrom
remove-suffix-from-tag

Conversation

@elfkuzco

@elfkuzco elfkuzco commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Changes

  • remove letter suffix from tags that would be generated when triggering app build. Even though different content versions produce the same base tag, the build number which is later added when interacting with github guarantees the overall tag would be different for the different content versions. Furthermore, CMS would use the latest book to trigger builds, so, higher build numbers would always point to higher content versions.

) -> AppBuildResult:
"""Create the next free tag pointing at sha and its release."""
base_tag = get_tag_prefix(app_name=app_name, content_version=content_version)
for build_number in range(100):
tag = f"{base_tag}.{build_number}"
if not self.create_tag(repo=repo, tag=tag, sha=sha):
continue
logger.info(f"Created tag '{tag}' for release on {repo}.")

@elfkuzco elfkuzco self-assigned this Nov 3, 2026
@elfkuzco
elfkuzco requested a review from benoit74 November 3, 2026 10:37
@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.41%. Comparing base (670caa2) to head (accfb79).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files          85       85           
  Lines        6048     6048           
  Branches      771      771           
=======================================
  Hits         4924     4924           
  Misses        892      892           
  Partials      232      232           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco
elfkuzco merged commit 9d6ec0b into main Nov 3, 2026
5 checks passed
@elfkuzco
elfkuzco deleted the remove-suffix-from-tag branch November 3, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants