ryanflannery fix: prevent secret exposure in settings API responses - #60
Open
ryanvflannery wants to merge 2 commits into
Open
Conversation
ryanvflannery
force-pushed
the
ryanflannery/fix/settings-secret-redaction
branch
from
June 4, 2026 09:20
6407ffe to
1485171
Compare
Collaborator
|
Settings secret redaction has since shipped (backend/apps/settings/redaction.py), resolving the exposure this targeted (#46). Closing as superseded, thank you for the security fix. |
Collaborator
|
Reopening, I closed this in error. I'd assumed it was superseded by backend/apps/settings/redaction.py, but that only redacts the SettingsRead MCP tool; the actual HTTP endpoint GET /api/settings (backend/apps/settings/settings.py:116) still returns the full model_dump() with every provider key plus the bearer token, unredacted. So this PR's mask-on-read / preserve-on-masked-write fix is still needed (see the PUT-clobber trap noted in the issue). Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redacts sensitive settings values returned by the settings API.
Changes
openswarm_bearer_tokenfrom settings responsesTesting
GET /api/settingsPUT /api/settingssettings.json