Skip to content

Set ImagePullPolicy to IfNotPresent on test pods#458

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
abays:fix/test-pod-pull-policy
Jun 22, 2026
Merged

Set ImagePullPolicy to IfNotPresent on test pods#458
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
abays:fix/test-pod-pull-policy

Conversation

@abays

@abays abays commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

BuildTestPod creates raw Pods directly without going through lib-common workload helpers, so the recently added pod.SetPullPolicyDefaults does not apply. When ImagePullPolicy is not explicitly set and the image tag is "latest" or unset, Kubernetes defaults the policy to Always. Explicitly set PullIfNotPresent to avoid unnecessary image pulls.

BuildTestPod creates raw Pods directly without going through
lib-common workload helpers, so the recently added
pod.SetPullPolicyDefaults does not apply. When ImagePullPolicy is
not explicitly set and the image tag is "latest" or unset,
Kubernetes defaults the policy to Always. Explicitly set
PullIfNotPresent to avoid unnecessary image pulls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@abays abays requested a review from kstrenkova June 22, 2026 14:32
@openshift-ci openshift-ci Bot requested review from lpiwowar and stuggi June 22, 2026 14:32

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 1bf5034 into openstack-k8s-operators:main Jun 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants