Set ImagePullPolicy to IfNotPresent on OpenStackClient pod#1949
Open
abays wants to merge 1 commit into
Open
Conversation
OpenStackControlPlane CRD Size Report
Threshold reference
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The OpenStackClient pod is created as a raw corev1.Pod directly, bypassing lib-common workload helpers where SetPullPolicyDefaults is applied. When ImagePullPolicy is not explicitly set and the image tag is "latest" or unset, Kubernetes defaults the policy to Always. Explicitly set PullIfNotPresent to avoid unnecessary image pulls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abays
force-pushed
the
fix/openstackclient-pull-policy
branch
from
5378dfb to
bb1efbb
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
Fixed indentation, adding LGTM label back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenStackClient pod is created as a raw corev1.Pod directly, bypassing lib-common workload helpers where SetPullPolicyDefaults is applied. When ImagePullPolicy is not explicitly set and the image tag is "latest" or unset, Kubernetes defaults the policy to Always. Explicitly set PullIfNotPresent to avoid unnecessary image pulls.