feat(nfv): add metricStorage replacement #773
Merged
centosinfra-prod-github-app[bot] merged 1 commit intoJun 22, 2026
Merged
Conversation
…values The NFV OVS-DPDK-SRIOV validated architecture enables telemetry and ceilometer via service-values replacements, but metricStorage (Prometheus monitoring stack) has no replacement — it stays at the base default of enabled: false regardless of what the deployer sets in service-values. This adds a kustomize replacement for telemetry.template.metricStorage.enabled so NFV deployments can toggle Prometheus metric collection through service-values.yaml, consistent with how telemetry.enabled and ceilometer.enabled are already handled. Also adds the metricStorage.enabled field to example service-values for both ovs-dpdk-sriov and ovs-dpdk-sriov-ipv6 to satisfy the kustomize replacement source requirement and provide a working default. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, aharivel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
centosinfra-prod-github-app
Bot
merged commit 2672fd9
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NFV OVS-DPDK-SRIOV validated architecture enables telemetry and ceilometer via service-values replacements, but metricStorage (Prometheus monitoring stack) has no replacement - it stays at the base default of enabled: false regardless of what the deployer sets in service-values.
This adds a kustomize replacement for telemetry.template.metricStorage.enabled so NFV deployments can toggle Prometheus metric collection through service-values.yaml, consistent with how telemetry.enabled and ceilometer.enabled are already handled.
Also adds the metricStorage.enabled field to example service-values for both ovs-dpdk-sriov and ovs-dpdk-sriov-ipv6 to satisfy the kustomize replacement source requirement and provide a working default.