Describe the Spring categories that only had a name - #1125
Merged
Conversation
Thirteen category descriptors carried a `name` and `packageName` but no `description`, while their siblings in the same file were fully described. This is not only cosmetic. Categories are matched by display name when the marketplace tree is assembled, so an undescribed category shadows a described one that shares its name. `Spring Boot 2.x` here was suppressing the description that `moderneinc/rewrite-spring` supplies for `io.moderne.java.spring.boot2`, which never reached users. All 27 descriptors in this file now reach the generated CSV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thirteen category descriptors in
category.ymlcarried anameandpackageNamebut nodescription, while their siblings in the same file —Spring Boot 4.x,Spring Cloud 2024,Spring Security 7.x— were fullydescribed. This fills them in, in the same style.
It is not purely cosmetic. Categories are matched by display name when the
marketplace tree is assembled, and the first one installed owns the node. An
undescribed category therefore shadows a described one that happens to share
its name.
Spring Boot 2.xhere was silently suppressing the description thatmoderneinc/rewrite-springsupplies forio.moderne.java.spring.boot2— thattext has never reached users, and no amount of fixing the downstream repo would
have surfaced it.
Verified by deleting
recipes.csvand regenerating: all 27 descriptors thatdeclare a description now reach the CSV, where 14 did before.
https://claude.ai/code/session_019r1a149dSe3VMXxtbPEPXs