Fix moving NPC vehicle pitch not synced

[Fanorisky]

rotation sent in driver sync previously only used yaw, so moving npc vehicles looked flat instead of tilting toward their direction of travel.
now pitch is calculated from position vs target position while moving_, then combined with yaw before sync.

[eakwarp]

@AmyrAhmady maybe its time?)
I tested the current implementation in all possible variants, and it's either this or NPC_SetQuaternion (from #1206 ) is needed

[AmyrAhmady]

Some comments and some empty line breaks are removed for some reason

[AmyrAhmady]

instead of doing things raw, can you use

const glm::vec3 delta = targetPosition_ - position_;

const float pitch = -atan2(delta.z, glm::length(glm::vec2(delta)));
const float yaw = glm::yaw(rotation_.q);

rotation_.q = glm::angleAxis(pitch, glm::vec3(1.0f, 0.0f, 0.0f)) * glm::angleAxis(yaw, glm::vec3(0.0f, 0.0f, 1.0f));

and put it in NPC::move instead of resetting it every sync packet broadcasting

[Fanorisky]

@AmyrAhmady thanks, that's much cleaner .
adopted it

[AmyrAhmady]

Please make sure you test it again in game after you made new changes, this would be my final change request and if you confirm it works in your test cases, I'll accept it

[AmyrAhmady]

I know this doesn't really change much, but since this line is meant to be for vehicles/driving only, let's move it in the if code block down there you made for moveType_ == NPCMoveType_Drive.

But remember it should be rotation_.x when you do.

[Fanorisky]

GTAQuat only has a glm::quat q member, so rotation_.x won't compile. also, rotation_.q.x is a quaternion component, not an euler angle.

but I think this line actually belongs in the non-drive path rather than the drive one. inside the drive block, the quaternion gets overwritten completely by the angleAxis composition, so a stale pitch there shouldn't really matter.

the case that actually needs it is when an NPC drives uphill and then gets told to walk. move() calls removeFromVehicle() itself, and sendFootSync() writes the full quaternion, so the ped keeps walking around tilted by 26.5° even on flat ground.

moving it into the if would also mean adding a matching else, which basically just means having the same line in both branches.