fix(ci): install libxml2 for the Windows release build - #130
Merged
Merged
Conversation
n-dusan
added a commit
that referenced
this pull request
Sep 17, 2026
The libxml build script finds libxml2 through vcpkg on MSVC, but the windows-latest runner has no libxml2 installed, so every release since v0.6.8 failed to upload a Windows binary. Install the x64-windows-static-md triplet (the vcpkg crate's default) and point VCPKG_ROOT at the runner's vcpkg.
n-dusan
force-pushed
the
ndusan/fix-windows-release-libxml2
branch
from
September 17, 2026 13:17
1720453 to
e0977f4
Compare
BojanG99
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
The
upload-assets (windows-latest)job of the Release workflow fails whilebuilding
taf-server(run 35223976783):
On MSVC targets the
libxmlbuild script looks up libxml2 through vcpkg, andnothing in the workflow installs it on the Windows runner. The Windows build has
failed the same way on every release since v0.6.8 (v0.6.8, v0.6.8-alpha.1,
v0.6.9-alpha.1, v0.6.9, v0.7.0-alpha.1), so none of those releases ship a
Windows binary.
The fix
cd.yml: on Windows only, runvcpkg install libxml2:x64-windows-static-mdbefore
upload-rust-binary-action, and setVCPKG_ROOTto the runner'spreinstalled vcpkg (
VCPKG_INSTALLATION_ROOT).x64-windows-static-mdis thetriplet the
vcpkgcrate looks for by default. It links libxml2 statically, sothe released
.zipworks without any libxml2 DLLs next to the executable.Checked
The fix is exercised by the Release workflow on the next tag push; the Windows
upload-assetsjob should now build and uploadtaf-server-x86_64-pc-windows-msvc-<tag>.zip.Code review checklist (for code reviewer to complete)
CHANGELOG.mdentry addedAutomated tests, benchmarks and linters
You can run the tests, lints and benchmarks that are run on CI locally with:
🤖 Generated with Claude Code