Nested expand#32
Open
hylkevds wants to merge 6 commits into
Open
Conversation
($count, $top, $skip, $select, $expand). * Added classes to model request so tests can be made generic.
… properties than just the name.
Contributor
|
There are many merge conflicts in this pull request. |
Contributor
Author
|
That may take a while. Especially since I wrote this almost 6 years ago. By now I thin we're both equally familiar with the code ;) |
|
Given that this Pull Request simply refactors some of the code and that the Pull Request is several years old, it has most likely been overtaken by events. I therefore propose that we close it without merging. This will avoid the risk of the refactoring breaking the ETS. If there is no objection, I will close it on 2022-11-07. |
Contributor
Author
|
It does a lot more than just refactor code, as is clearly explained in the PR text. |
|
@hylkevds Ok, understood. If you can help to resolve the code conflicts that would be appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests nested expands, with $top, $skip, $select and $count options for those nested expands.
Since the set of methods that can actually check results for this type of query can also fully check the simple test results for $expand, $top, $skip, $count and $select, I replaced the check for those as well in the last commit. This shortens Capability3Tests.java by a lot and no longer depends on odd string magic.
This continues on pull request #29